Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OidcBackChannelLogoutTokenValidator should not construct when missing OIDC Provider Issuer #15824

Merged
merged 2 commits into from
Sep 30, 2024
Merged

OidcBackChannelLogoutTokenValidator should not construct when missing OIDC Provider Issuer #15824

merged 2 commits into from
Sep 30, 2024

Conversation

wapkch
Copy link

@wapkch wapkch commented Sep 18, 2024

Closes gh-15771

@wapkch wapkch changed the base branch from main to 6.2.x September 18, 2024 15:00
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 18, 2024
jzheaux
jzheaux requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @wapkch! I left a piece of feedback inline. Please see if you can apply it also to the reactive implementation and update the tests accordingly.

...ity/config/annotation/web/configurers/oauth2/client/OidcBackChannelLogoutTokenValidator.java Outdated Show resolved Hide resolved
@jzheaux jzheaux self-assigned this Sep 18, 2024
@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Sep 18, 2024
@jzheaux jzheaux changed the title Fix NPE in OidcBackChannelLogoutTokenValidator when OIDC Provider Issuer is missing OidcBackChannelLogoutTokenValidator should not construct when missing OIDC Provider Issuer Sep 18, 2024
@jzheaux jzheaux added this to the 6.4.0-RC1 milestone Sep 23, 2024
@jzheaux jzheaux merged commit c1857c0 into spring-projects:6.2.x Sep 30, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Sep 30, 2024

Thanks again, @wapkch, this is now merged into 6.2.x, 6.3.x, and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
None yet
Milestone
6.4.0-RC1
Development

Successfully merging this pull request may close these issues.

OidcBackChannelLogoutTokenValidator should not throw an NPE when issuer is missing
3 participants
@wapkch @jzheaux @spring-projects-issues