Improve documentation about CredentialsContainer #15554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi @Chu3laMan, thanks for the PR! Would you mind clarifying why you replaced the |
marcusdacoregio
added
in: docs
Hi @marcusdacoregio thank you for your remark, I already fix it ... could you check por favor? |
sjohnr
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Thank you for the PR @Chu3laMan. I have added a few comments inline below.
docs/modules/ROOT/pages/servlet/authentication/architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/architecture.adoc
Outdated
Show resolved
Hide resolved
sjohnr
added
the
status: waiting-for-feedback
sjohnr
force-pushed
the
feature/15398-credentialsContainer
branch
from
75d52de
to
909dcc6
Compare
sjohnr
added a commit
to Chu3laMan/spring-security
that referenced
this pull request
Nov 13, 2024
sjohnr
force-pushed
the
feature/15398-credentialsContainer
branch
from
909dcc6
to
81808c5
Compare
sjohnr
removed
the
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.