Fix compatibility with Java 8 for ByteBuffer #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we build with Java 9+ and target for Java 8, we get an incompatible bytecode around these method for `ByteBuffer`: ``` position(int) limit(int) mark() reset() clear() flip() rewind() ``` The recommendation is to cast to `Buffer` when we call these methods * Fix all the production code using `ByteBuffer` for recommended cast to `Buffer` Related to https://build.spring.io/browse/INTEXT-AWS-306 See more info in this Jetty issue: jetty/jetty.project#3244
|
Also #3470 We must not have any samples that hit any of these other classes 😦 |
|
Yeah... Doesn't matter. It's great to catch it sooner than later. Plus it is just in time for for upcoming RC 😄 |
garyrussell
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we build with Java 9+ and target for Java 8,
we get an incompatible bytecode around these method for
ByteBuffer:The recommendation is to cast to
Bufferwhen we call these methodsByteBufferfor recommended cast toBufferRelated to https://build.spring.io/browse/INTEXT-AWS-306
See more info in this Jetty issue: jetty/jetty.project#3244