[5.3.x] Fix JettyWebSocketSession.getRemoteAddress throwing instead of returning null with Jetty 10 #33620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing null with Jetty 10
|
@Spikhalskiy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Spikhalskiy Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
Spikhalskiy
force-pushed
the
5.3.x-fix-IllegalArgumentExceptionon
branch
from
43a3aec
to
e4a8493
Compare
Spikhalskiy
changed the title
Spikhalskiy
force-pushed
the
5.3.x-fix-IllegalArgumentExceptionon
branch
from
e4a8493
to
43a3aec
Compare
|
See #33619 |
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add graceful processing of
org.eclipse.jetty.websocket.api.Session#getRemoteAddressreturning null for Jetty 10Closes #33619
This PR doesn't need a port to 5.2.x or 6+ branches. 5.2.x and 6.x branches handle this code identically, in a simple way, for two different jetty versions not maintaining compatibility between them.
5.3.x has Jetty 9 and 10 compatibility layer which introduced the problem.