Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added read-committed transaction isolation and consistency support to TransactionAwareCacheDecorator #32755

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

werner77
Copy link

@werner77 werner77 commented May 3, 2024

The decorator now maintains consistency within the transaction and ensures all changes are only
committed to the target cache on successful completion of the transaction.

  • Added complete isolation and consistency support for concurrent transactions.
  • Added accompanying Javadoc documentation.
  • Added unit test testing the isolation properties introduced.
  • Maintained backwards compatibility (existing unit test is still there and succeeds)

See also issue: #17353

…eCacheDecorator.

- Added complete isolation and consistency support for concurrent transactions.
- Added accompanying Javadoc documentation.
- Added unit test testing the isolation properties introduced.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 3, 2024
@jhoeller jhoeller added the in: data Issues in data modules (jdbc, orm, oxm, tx) label May 3, 2024
@werner77 werner77 changed the title Added read-committed transaction isolation support to TransactionAwareCacheDecorator Added read-committed transaction isolation and consistency support to TransactionAwareCacheDecorator May 4, 2024
if (wrapper != null) {
// Unwrap
final var value = convertValue(wrapper);
return cast(value, type);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential NPE, consider handling the case where convertValue(wrapper) returns null before calling cast(value, type).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: waiting-for-triage An issue we've not yet triaged or decided on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants