-
Notifications
You must be signed in to change notification settings - Fork 38.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add runtime hints for JMS connection factories proxies
Prior to this commit, the JMS connection factories would proxy various interfaces. This typically requires runtime hints for GraalVM native applications and spring-jms is missing those. This commit adds a new `ConnectionFactoriesRuntimeHints` that contributes such hints with type conditions. Fixes gh-33590
- Loading branch information
Showing
3 changed files
with
107 additions
and
0 deletions.
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
...jms/src/main/java/org/springframework/jms/connection/ConnectionFactoriesRuntimeHints.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Copyright 2002-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.jms.connection; | ||
|
||
import jakarta.jms.Connection; | ||
import jakarta.jms.QueueConnection; | ||
import jakarta.jms.QueueSession; | ||
import jakarta.jms.TopicConnection; | ||
import jakarta.jms.TopicSession; | ||
|
||
import org.springframework.aot.hint.RuntimeHints; | ||
import org.springframework.aot.hint.RuntimeHintsRegistrar; | ||
import org.springframework.aot.hint.TypeReference; | ||
import org.springframework.lang.Nullable; | ||
|
||
/** | ||
* {@link RuntimeHintsRegistrar} to register hints for JMS connection factories. | ||
* | ||
* @author Brian Clozel | ||
* @see CachingConnectionFactory | ||
* @see SingleConnectionFactory | ||
* @see TransactionAwareConnectionFactoryProxy | ||
*/ | ||
class ConnectionFactoriesRuntimeHints implements RuntimeHintsRegistrar { | ||
|
||
@Override | ||
public void registerHints(RuntimeHints hints, @Nullable ClassLoader classLoader) { | ||
hints.proxies().registerJdkProxy(builder -> builder.onReachableType(TypeReference.of(CachingConnectionFactory.class)) | ||
.proxiedInterfaces(SessionProxy.class, TopicSession.class, QueueSession.class)); | ||
hints.proxies().registerJdkProxy(builder -> builder.onReachableType(TypeReference.of(SingleConnectionFactory.class)) | ||
.proxiedInterfaces(Connection.class, QueueConnection.class, TopicConnection.class)); | ||
hints.proxies().registerJdkProxy(builder -> builder.onReachableType(TypeReference.of(TransactionAwareConnectionFactoryProxy.class)) | ||
.proxiedInterfaces(Connection.class, QueueConnection.class, TopicConnection.class)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
org.springframework.aot.hint.RuntimeHintsRegistrar=\ | ||
org.springframework.jms.connection.ConnectionFactoriesRuntimeHints |
56 changes: 56 additions & 0 deletions
56
...rc/test/java/org/springframework/jms/connection/ConnectionFactoriesRuntimeHintsTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Copyright 2002-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.jms.connection; | ||
|
||
import jakarta.jms.Connection; | ||
import jakarta.jms.QueueConnection; | ||
import jakarta.jms.QueueSession; | ||
import jakarta.jms.TopicConnection; | ||
import jakarta.jms.TopicSession; | ||
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import org.springframework.aot.hint.RuntimeHints; | ||
import org.springframework.aot.hint.RuntimeHintsRegistrar; | ||
import org.springframework.aot.hint.predicate.RuntimeHintsPredicates; | ||
import org.springframework.core.io.support.SpringFactoriesLoader; | ||
import org.springframework.util.ClassUtils; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
/** | ||
* Tests for {@link ConnectionFactoriesRuntimeHints}. | ||
*/ | ||
class ConnectionFactoriesRuntimeHintsTests { | ||
|
||
private RuntimeHints hints; | ||
|
||
@BeforeEach | ||
void setup() { | ||
this.hints = new RuntimeHints(); | ||
SpringFactoriesLoader.forResourceLocation("META-INF/spring/aot.factories") | ||
.load(RuntimeHintsRegistrar.class).forEach(registrar -> registrar | ||
.registerHints(this.hints, ClassUtils.getDefaultClassLoader())); | ||
} | ||
|
||
@Test | ||
void shouldRegisterProxyHints() throws Exception { | ||
assertThat(RuntimeHintsPredicates.proxies().forInterfaces(SessionProxy.class, TopicSession.class, QueueSession.class)).accepts(this.hints); | ||
assertThat(RuntimeHintsPredicates.proxies().forInterfaces(Connection.class, QueueConnection.class, TopicConnection.class)).accepts(this.hints); | ||
} | ||
|
||
} |