Add elasticsearch repository test #679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
@sothawo what do you think? |
|
I will have a look, but cannot do this before the next weekend |
sothawo
reviewed
Sep 14, 2024
| result.forEach(it -> verify(it, expectedWord, expectedDate)); | ||
| } | ||
|
|
||
| private void verify(Conference it, String expectedWord, LocalDate expectedDate) { |
| @@ -51,16 +55,16 @@ public void insertDataSample() { | |||
| // Save data sample | |||
|
|
|||
| var documents = Arrays.asList( | |||
| Conference.builder().date("2014-11-06").name("Spring eXchange 2014 - London") | |||
| Conference.builder().date(LocalDate.parse("2014-11-06", FORMAT)).name("Spring eXchange 2014 - London") | |||
There was a problem hiding this comment.
instead of parsing, wouldn't it be better to use
LocalDate.of(2014,11,6)
| protected static final DateTimeFormatter FORMAT = DateTimeFormatter.ISO_LOCAL_DATE; | ||
|
|
||
| private static final ElasticsearchContainer CONTAINER = new ElasticsearchContainer( | ||
| DockerImageName.parse("docker.elastic.co/elasticsearch/elasticsearch:8.7.0")) // |
There was a problem hiding this comment.
The current released version of Spring Data Elasticsearch is built against Elasticsearch 8.13.4 so. would at least use that.
| @Test | ||
| void textSearch() { | ||
|
|
||
| var expectedDate = LocalDate.parse("2014-10-29", FORMAT); |
| protected static final DateTimeFormatter FORMAT = DateTimeFormatter.ISO_LOCAL_DATE; | ||
|
|
||
| private static final ElasticsearchContainer CONTAINER = new ElasticsearchContainer( | ||
| DockerImageName.parse("docker.elastic.co/elasticsearch/elasticsearch:8.7.0")) // |
mp911de
added
the
status: waiting-for-feedback
|
Closing as this pull request wasn't updated in time. If you would like us to look at this issue, please provide additional information and we will re-open the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalDaterather thanStringtype to match the annotation@Field(type = Date). The formerStringtype is a misuse of date type and will cause the following warn: