Provide a configuration property for configuring Jetty's max form keys #42448
Conversation
|
@qingbozhang Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@qingbozhang Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
|
Hi I’d appreciate a review when you have a moment. Thanks! |
|
We're a small team with many different priorities. Expecting a review within two days of opening a PR isn't realistic. Someone will review this when we have time. Thank you for your patience in the meantime. |
|
OK, thank you |
| @@ -1148,6 +1148,11 @@ public static class Jetty { | |||
| */ | |||
| private DataSize maxHttpFormPostSize = DataSize.ofBytes(200000); | |||
|
|
|||
| /** | |||
| * Maximum size of the form keys. | |||
There was a problem hiding this comment.
It's not really a size, is it? How about "Maximum number of form keys."
| @@ -1180,6 +1185,14 @@ public void setMaxHttpFormPostSize(DataSize maxHttpFormPostSize) { | |||
| this.maxHttpFormPostSize = maxHttpFormPostSize; | |||
| } | |||
|
|
|||
| public int getMaxFormKeys() { | |||
| return maxFormKeys; | |||
| @@ -122,7 +127,7 @@ private void customizeIdleTimeout(ConfigurableJettyWebServerFactory factory, Dur | |||
| }); | |||
| } | |||
|
|
|||
| private void customizeMaxHttpFormPostSize(ConfigurableJettyWebServerFactory factory, int maxHttpFormPostSize) { | |||
| private void customizeServletContextHandler(ConfigurableJettyWebServerFactory factory, Consumer<ServletContextHandler> customFunc) { | |||
There was a problem hiding this comment.
Before your change this method adds a customizer that is very much specific to maxHttpFormPostSize. The private method is still named setHandlerMaxHttpFormPostSize so that should change so that it is more clear that the intent is to customize the ServletContextHandler.
| .to((maxHttpFormPostSize) -> customizeMaxHttpFormPostSize(factory, maxHttpFormPostSize)); | ||
| .to((maxHttpFormPostSize) -> customizeServletContextHandler(factory, contextHandler -> contextHandler.setMaxFormContentSize(maxHttpFormPostSize))); | ||
| map.from(properties::getMaxFormKeys) | ||
| .when(this::isPositive) |
There was a problem hiding this comment.
That's a copy/paste of the mapping above. I am not sure it applies equally for this property.
snicoll
added
the
status: waiting-for-feedback
I encountered an issue in the project related to form submissions, where the number of keys exceeded Jetty's default limit of 1000. I found that there's no way to configure this parameter in the Spring Boot configuration file.
Although I achieved my goal by setting
org.eclipse.jetty.server.Request.maxFormKeys, it doesn't feel like an ideal solution.May I submit a PR to add this configuration option?