Add DB2 support for Docker Compose #42395

quaff · 2024-09-20T08:55:58Z

No description provided.

quaff · 2024-09-25T01:52:36Z

Db2R2dbcDockerComposeConnectionDetailsFactory removed since com.ibm.db2:db2-r2dbc is not an actual driver.

Unable to create a ConnectionFactory for 'ConnectionFactoryOptions{options={database=testdb, host=127.0.0.1, driver=db2, password=REDACTED, port=50000, user=db2inst1}}'. Available drivers: [ oracle, sqlserver, postgresql ]
java.lang.IllegalStateException: Unable to create a ConnectionFactory for 'ConnectionFactoryOptions{options={database=testdb, host=127.0.0.1, driver=db2, password=REDACTED, port=50000, user=db2inst1}}'. Available drivers: [ oracle, sqlserver, postgresql ]
	at io.r2dbc.spi.ConnectionFactories.get(ConnectionFactories.java:143)

...st/resources/org/springframework/boot/docker/compose/service/connection/db2/db2-compose.yaml

quaff · 2024-09-25T03:09:46Z

Need more disk space to run tests.

mhalbritter

Thanks for the PR, @quaff . I've left some comments for your consideration.

...t-support-docker/src/main/java/org/springframework/boot/testsupport/container/TestImage.java

mhalbritter · 2024-09-25T13:56:03Z

...st/resources/org/springframework/boot/docker/compose/service/connection/db2/db2-compose.yaml

+    image: '{imageName}'
+    ports:
+      - '50000'
+    privileged: true


I don't think you can run privileged containers on the CI. Why is that needed?

Otherwise Connection reset exception always be thrown, that's why testcontainers Db2Container need that also.
https://github.com/testcontainers/testcontainers-java/blob/04206d9dff440e875906f01151f09ad04da3c68f/modules/db2/src/main/java/org/testcontainers/containers/Db2Container.java#L60

...st/resources/org/springframework/boot/docker/compose/service/connection/db2/db2-compose.yaml

snicoll

I've added some comment, please have a look when you get a chance.

spring-boot-project/spring-boot-docker-compose/build.gradle

...t-support-docker/src/main/java/org/springframework/boot/testsupport/container/TestImage.java

spring-boot-project/spring-boot-tools/spring-boot-test-support-docker/build.gradle

snicoll · 2024-09-30T12:29:45Z

...st/resources/org/springframework/boot/docker/compose/service/connection/db2/db2-compose.yaml

+      - '50000'
+    privileged: true
+    environment:
+      - 'LICENSE=accept'


What does this mean in practice?

Which part?

The LICENSE=accept bit.

It's required by starting DB2 instance, testcontainers' DB2Container need this also. see https://github.com/testcontainers/testcontainers-java/blob/04206d9dff440e875906f01151f09ad04da3c68f/modules/db2/src/main/java/org/testcontainers/containers/Db2Container.java#L104

I understand that it's required, I am asking what it means in practice that our project starts accepting that license.

Not for production use, I guess.

I don't think this is resolved as we haven't determined if we can legally accept the license for testing purposes. Knowing that Testcontainers has support for accepting the license is useful but it's opt-in and doesn't tell us if we can do the same automatically on CI and dev machines for testing purposes.

It's not opt-in, Testcontainers accept the license by default.

License is not accepted by default in Testcontainers. User must call acceptLicense(), which sets the env var, when defining Db2Container. See https://github.com/testcontainers/testcontainers-java/blob/main/modules/db2/src/test/java/org/testcontainers/junit/db2/SimpleDb2Test.java#L17

My mistake, I forgot I added container-license-acceptance.txt.

...t-support-docker/src/main/java/org/springframework/boot/testsupport/container/TestImage.java

...ct/spring-boot-docs/src/docs/antora/modules/appendix/pages/application-properties/index.adoc

wilkinsona · 2024-10-10T09:23:36Z

I've force-pushed this having rebased it on the latest main. That should mean the PR picks up some recent changes to the runner preparation that will make more free disk space available.

wilkinsona · 2024-10-14T15:38:53Z

This is blocked until the questions regarding the licence acceptance have been resolved.

philwebb · 2024-10-15T21:19:20Z

I looks like DB2 is also being removed from Docker Hub (see https://community.ibm.com/community/user/datamanagement/blogs/vijaya-katikireddy/2023/02/04/db2-community). Given that and the license issues, I'm not sure that we should try to support this.

quaff · 2024-10-16T00:42:51Z

I looks like DB2 is also being removed from Docker Hub (see https://community.ibm.com/community/user/datamanagement/blogs/vijaya-katikireddy/2023/02/04/db2-community). Given that and the license issues, I'm not sure that we should try to support this.

This PR use new icr.io/db2_community/db2 for test.

wilkinsona · 2024-10-16T09:46:50Z

I believe that this is the relevant license.

It contains the following usage restriction:

1. Usage Restrictions

(a) The Program may use a maximum of 4 processor cores and 16 GB of memory on each physical or virtual server.

I think we could comply with the license by setting some CPU and memory limits in the compose files used for testing. Whether or not it's worth the trouble is another question.

philwebb · 2024-10-16T17:20:04Z

I think unfortunately the usage restrictions, combined with the fact that the image isn't in Docker Hub means we probably shouldn't add support for this. Thanks anyway for the PR @quaff!

quaff marked this pull request as draft September 20, 2024 08:56

spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 20, 2024

quaff force-pushed the patch-72 branch 3 times, most recently from ba97968 to e7b437f Compare September 25, 2024 01:48

quaff marked this pull request as ready for review September 25, 2024 01:52

quaff commented Sep 25, 2024

View reviewed changes

...st/resources/org/springframework/boot/docker/compose/service/connection/db2/db2-compose.yaml Outdated Show resolved Hide resolved

quaff force-pushed the patch-72 branch 3 times, most recently from c7bbd7d to 99e6757 Compare September 25, 2024 09:32

mhalbritter reviewed Sep 25, 2024

View reviewed changes

mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Sep 25, 2024

quaff force-pushed the patch-72 branch from 99e6757 to 90b4b8b Compare September 26, 2024 00:50

snicoll requested changes Sep 30, 2024

View reviewed changes

quaff force-pushed the patch-72 branch from 90b4b8b to ff06838 Compare October 8, 2024 01:19

snicoll reviewed Oct 8, 2024

View reviewed changes

...ct/spring-boot-docs/src/docs/antora/modules/appendix/pages/application-properties/index.adoc Outdated Show resolved Hide resolved

quaff force-pushed the patch-72 branch from ff06838 to 3321495 Compare October 8, 2024 08:52

snicoll added the for: team-meeting An issue we'd like to discuss as a team to make progress label Oct 8, 2024

wilkinsona force-pushed the patch-72 branch from 3321495 to 4252090 Compare October 10, 2024 09:20

wilkinsona force-pushed the patch-72 branch from 4252090 to da05e9e Compare October 10, 2024 10:59

Add DB2 support for Docker Compose

295b73e

wilkinsona force-pushed the patch-72 branch from da05e9e to 295b73e Compare October 10, 2024 14:24

wilkinsona added status: blocked An issue that's blocked on an external project change and removed for: team-meeting An issue we'd like to discuss as a team to make progress labels Oct 14, 2024

philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Oct 15, 2024

spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Oct 16, 2024

philwebb closed this Oct 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DB2 support for Docker Compose #42395

Add DB2 support for Docker Compose #42395

quaff commented Sep 20, 2024

quaff commented Sep 25, 2024

quaff commented Sep 25, 2024

mhalbritter left a comment

mhalbritter Sep 25, 2024 •

edited

Loading

quaff Sep 26, 2024

snicoll left a comment

snicoll Sep 30, 2024

quaff Oct 8, 2024

snicoll Oct 8, 2024

quaff Oct 8, 2024

snicoll Oct 8, 2024

quaff Oct 8, 2024

wilkinsona Oct 9, 2024

quaff Oct 10, 2024

eddumelendez Oct 10, 2024

quaff Oct 10, 2024

wilkinsona commented Oct 10, 2024

wilkinsona commented Oct 14, 2024

philwebb commented Oct 15, 2024

quaff commented Oct 16, 2024

wilkinsona commented Oct 16, 2024

philwebb commented Oct 16, 2024

Add DB2 support for Docker Compose #42395

Add DB2 support for Docker Compose #42395

Conversation

quaff commented Sep 20, 2024

quaff commented Sep 25, 2024

quaff commented Sep 25, 2024

mhalbritter left a comment

Choose a reason for hiding this comment

mhalbritter Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snicoll left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wilkinsona commented Oct 10, 2024

wilkinsona commented Oct 14, 2024

philwebb commented Oct 15, 2024

quaff commented Oct 16, 2024

wilkinsona commented Oct 16, 2024

philwebb commented Oct 16, 2024

mhalbritter Sep 25, 2024 •

edited

Loading