Skip to content

feat: ChatClient#mutate adds copies of advisors and advisorParams. #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

YunKuiLu
Copy link
Contributor

@YunKuiLu YunKuiLu commented Jun 6, 2025

  • The mutate() method adds copies of advisors and advisorParams.
  • Add unit test to validate mutate() behavior.

- The `mutate()` method adds copies of `advisors` and `advisorParams`.
- Add unit test to validate `mutate()` behavior.

Signed-off-by: YunKui Lu <[email protected]>
@ilayaperumalg ilayaperumalg added this to the 1.1.x milestone Jun 6, 2025
@ilayaperumalg ilayaperumalg self-assigned this Jun 18, 2025
spring-builds pushed a commit that referenced this pull request Jun 18, 2025
Fixes #3459

- The `mutate()` method adds copies of `advisors` and `advisorParams`.
- Add unit test to validate `mutate()` behavior.

Signed-off-by: YunKui Lu <[email protected]>
(cherry picked from commit f391ff2)
@ilayaperumalg
Copy link
Member

@YunKuiLu Thanks for the PR. Rebased and merged as f391ff2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants