Skip to content

fix issue@ #2399 #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Forest-Fairy
Copy link

resolved the cache problem with tcb by identity the hash of tool bean

@markpollack
Copy link
Member

You mentioned in the issue that using an ApplicationEventListener would be a more appropriate way to handle this. Thoughts?

@Forest-Fairy
Copy link
Author

You mentioned in the issue that using an ApplicationEventListener would be a more appropriate way to handle this. Thoughts?

yes, I had sent a pr to resolve this problem with that, but i found another problem that if the resolver is not a bean in spring then we should remove cache manually. this will complicate the resolver's using. however getting bean every time may cost more time than before but it simplifies the using.

@Forest-Fairy
Copy link
Author

You mentioned in the issue that using an ApplicationEventListener would be a more appropriate way to handle this. Thoughts?

yes, I had sent a pr to resolve this problem with that, but i found another problem that if the resolver is not a bean in spring then we should remove cache manually. this will complicate the resolver's using. however getting bean every time may cost more time than before but it simplifies the using.

the prototype tool bean will also be supported in this way, and probably the time that it costs more is still in a range that user is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants