-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(core): Add Supplier and Consumer function callback support #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tzolov
wants to merge
3
commits into
spring-projects:main
from
tzolov:support-consumer-supplier-function-calling-v2
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,9 +17,12 @@ | |
package org.springframework.ai.model.function; | ||
|
||
import java.util.function.BiFunction; | ||
import java.util.function.Consumer; | ||
import java.util.function.Function; | ||
import java.util.function.Supplier; | ||
|
||
import com.fasterxml.jackson.annotation.JsonClassDescription; | ||
import kotlin.jvm.functions.Function0; | ||
import kotlin.jvm.functions.Function1; | ||
import kotlin.jvm.functions.Function2; | ||
|
||
|
@@ -30,6 +33,7 @@ | |
import org.springframework.context.annotation.Description; | ||
import org.springframework.context.support.GenericApplicationContext; | ||
import org.springframework.core.KotlinDetector; | ||
import org.springframework.core.ParameterizedTypeReference; | ||
import org.springframework.core.ResolvableType; | ||
import org.springframework.lang.NonNull; | ||
import org.springframework.lang.Nullable; | ||
|
@@ -71,7 +75,8 @@ public void setApplicationContext(@NonNull ApplicationContext applicationContext | |
public FunctionCallback getFunctionCallback(@NonNull String beanName, @Nullable String defaultDescription) { | ||
|
||
ResolvableType functionType = TypeResolverHelper.resolveBeanType(this.applicationContext, beanName); | ||
ResolvableType functionInputType = TypeResolverHelper.getFunctionArgumentType(functionType, 0); | ||
ResolvableType functionInputType = (ResolvableType.forType(Supplier.class).isAssignableFrom(functionType)) | ||
? ResolvableType.forType(Void.class) : TypeResolverHelper.getFunctionArgumentType(functionType, 0); | ||
|
||
Class<?> functionInputClass = functionInputType.toClass(); | ||
String functionDescription = defaultDescription; | ||
|
@@ -109,15 +114,23 @@ public FunctionCallback getFunctionCallback(@NonNull String beanName, @Nullable | |
.schemaType(this.schemaType) | ||
.description(functionDescription) | ||
.function(beanName, KotlinDelegate.wrapKotlinFunction(bean)) | ||
.inputType(functionInputClass) | ||
.inputType(ParameterizedTypeReference.forType(functionInputType.getType())) | ||
.build(); | ||
} | ||
else if (KotlinDelegate.isKotlinBiFunction(functionType.toClass())) { | ||
return FunctionCallback.builder() | ||
.description(functionDescription) | ||
.schemaType(this.schemaType) | ||
.function(beanName, KotlinDelegate.wrapKotlinBiFunction(bean)) | ||
.inputType(functionInputClass) | ||
.inputType(ParameterizedTypeReference.forType(functionInputType.getType())) | ||
.build(); | ||
} | ||
else if (KotlinDelegate.isKotlinSupplier(functionType.toClass())) { | ||
return FunctionCallback.builder() | ||
.description(functionDescription) | ||
.schemaType(this.schemaType) | ||
.function(beanName, KotlinDelegate.wrapKotlinSupplier(bean)) | ||
.inputType(ParameterizedTypeReference.forType(functionInputType.getType())) | ||
.build(); | ||
} | ||
} | ||
|
@@ -126,15 +139,31 @@ else if (KotlinDelegate.isKotlinBiFunction(functionType.toClass())) { | |
.schemaType(this.schemaType) | ||
.description(functionDescription) | ||
.function(beanName, function) | ||
.inputType(functionInputClass) | ||
.inputType(ParameterizedTypeReference.forType(functionInputType.getType())) | ||
.build(); | ||
} | ||
else if (bean instanceof BiFunction<?, ?, ?>) { | ||
return FunctionCallback.builder() | ||
.description(functionDescription) | ||
.schemaType(this.schemaType) | ||
.function(beanName, (BiFunction<?, ToolContext, ?>) bean) | ||
.inputType(functionInputClass) | ||
.inputType(ParameterizedTypeReference.forType(functionInputType.getType())) | ||
.build(); | ||
} | ||
else if (bean instanceof Supplier<?> supplier) { | ||
return FunctionCallback.builder() | ||
.description(functionDescription) | ||
.schemaType(this.schemaType) | ||
.function(beanName, supplier) | ||
.inputType(ParameterizedTypeReference.forType(functionInputType.getType())) | ||
.build(); | ||
} | ||
else if (bean instanceof Consumer<?> consumer) { | ||
return FunctionCallback.builder() | ||
.description(functionDescription) | ||
.schemaType(this.schemaType) | ||
.function(beanName, consumer) | ||
.inputType(ParameterizedTypeReference.forType(functionInputType.getType())) | ||
.build(); | ||
} | ||
else { | ||
|
@@ -150,6 +179,15 @@ public enum SchemaType { | |
|
||
private static class KotlinDelegate { | ||
|
||
public static boolean isKotlinSupplier(Class<?> clazz) { | ||
return Function0.class.isAssignableFrom(clazz); | ||
} | ||
|
||
@SuppressWarnings("unchecked") | ||
public static Supplier<?> wrapKotlinSupplier(Object function) { | ||
return () -> ((Function0<Object>) function).invoke(); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Likely we may have to add support for the Kotlin's equivalent of java.util.Consumer() in a follow up PR. |
||
|
||
public static boolean isKotlinFunction(Class<?> clazz) { | ||
return Function1.class.isAssignableFrom(clazz); | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we will need support for the Kotlin's equivalent of java.util.Consumer?
But this can be implemented in a follow up PR.