Skip to content

Add support for @Component to TypeResolverHelper #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,16 @@ else if (isParamMismatch(uniqueCandidate, candidate)) {
rootBeanDefinition.setResolvedFactoryMethod(uniqueCandidate);
return rootBeanDefinition.getResolvableType();
}
// Support for @Component
if (beanDefinition.getFactoryMethodName() == null && beanDefinition.getBeanClassName() != null) {
try {
return ResolvableType.forClass(
ClassUtils.forName(beanDefinition.getBeanClassName(), applicationContext.getClassLoader()));
}
catch (ClassNotFoundException ex) {
throw new IllegalArgumentException("Impossible to resolve the type of bean " + beanName, ex);
}
}
throw new IllegalArgumentException("Impossible to resolve the type of bean " + beanName);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@
import static org.assertj.core.api.Assertions.assertThat;

@SpringBootTest
class TypeResolverHelperIT {
public class TypeResolverHelperIT {

@Autowired
GenericApplicationContext applicationContext;

@ParameterizedTest(name = "{0} : {displayName} ")
@ValueSource(strings = { "weatherClassDefinition", "weatherFunctionDefinition", "standaloneWeatherFunction",
"scannedStandaloneWeatherFunction" })
"scannedStandaloneWeatherFunction", "componentWeatherFunction" })
void beanInputTypeResolutionWithResolvableType(String beanName) {
assertThat(this.applicationContext).isNotNull();
ResolvableType functionType = TypeResolverHelper.resolveBeanType(this.applicationContext, beanName);
Expand Down Expand Up @@ -70,7 +70,8 @@ public WeatherResponse apply(WeatherRequest weatherRequest) {
}

@Configuration
@ComponentScan("org.springframework.ai.model.function.config")
@ComponentScan({ "org.springframework.ai.model.function.config",
"org.springframework.ai.model.function.component" })
public static class TypeResolverHelperConfiguration {

@Bean
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/*
* Copyright 2023-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.ai.model.function.component;

import java.util.function.Function;

import org.springframework.ai.model.function.TypeResolverHelperIT.WeatherRequest;
import org.springframework.ai.model.function.TypeResolverHelperIT.WeatherResponse;
import org.springframework.stereotype.Component;

/**
* @author Sebastien Deleuze
*/
@Component
public class ComponentWeatherFunction implements Function<WeatherRequest, WeatherResponse> {

@Override
public WeatherResponse apply(WeatherRequest weatherRequest) {
return new WeatherResponse(42.0f);
}

}