Skip to content

rename timeToLiveSeconds of cassandra property #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

rename timeToLiveSeconds of cassandra property #1737

wants to merge 1 commit into from

Conversation

jitokim
Copy link
Contributor

@jitokim jitokim commented Nov 14, 2024 •
edited
Loading

fix issue #1728

rename timeToLiveSeconds to timeToLive because the type is Duration.

add test code for ISO-8601 Format and also numeric type

image image

@jitokim
Copy link
Contributor Author

jitokim commented Nov 14, 2024

The reason I changed the name of timeToLiveSeconds without changing its type is,

Using the Duration type allows us to preserve the ISO-8601 format, but its default unit is milliseconds.

To keep the function name (withTimeToLive) and its parameter type (Duration) consistent in the CassandraChatMemoryConfig class.

tusharleek
tusharleek approved these changes Nov 14, 2024
View reviewed changes
Copy link

@tusharleek tusharleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add any comments in documentation or here that specify we are expecting this value in milliseconds

@tzolov tzolov added this to the 1.0.0-M4 milestone Nov 18, 2024
@markpollack markpollack self-assigned this Nov 18, 2024
@markpollack
Copy link
Member

Thanks, merged in a7a1804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharleek tusharleek tusharleek approved these changes

Assignees

@markpollack markpollack

Labels
vector store
Projects
None yet
Milestone
1.0.0-M4
Development

Successfully merging this pull request may close these issues.
4 participants
@jitokim @markpollack @tusharleek @tzolov