Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape kotlin package name which contains fun #1551

Closed
wants to merge 1 commit into from

Conversation

Ant00000ny
Copy link
Contributor

fix #1550

@pivotal-cla
Copy link

@Ant00000ny Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@Ant00000ny Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 2, 2024
@mhalbritter
Copy link
Contributor

Hey, thanks for the PR. I think we should tackle this in a broader way - checking for all Kotlin keywords, like we do for Java in io.spring.initializr.metadata.InitializrConfiguration#hasReservedKeyword.

@mhalbritter mhalbritter closed this Jul 3, 2024
@mhalbritter mhalbritter added status: declined and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating a Kotlin project with a package name containing keywords will result in an unusable project
4 participants