Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README - Intellij IDEA Community Support with Plugin #1499

Closed
wants to merge 1 commit into from

Conversation

eltonsandre
Copy link

Added in readme - Intellij IDEA Community Support with Plugin

Added in readme - Intellij IDEA Community Support with Plugin
@pivotal-cla
Copy link

@eltonsandre Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 22, 2024
@pivotal-cla
Copy link

@eltonsandre Thank you for signing the Contributor License Agreement!

@mhalbritter
Copy link
Contributor

mhalbritter commented Feb 1, 2024

Hey, thanks for the PR. I've looked at your plugin and I'm hesitant to add it to our README because it doesn't seem widely used. I might reconsider if this gains some traction. If it goes through the roof (which I hope for you), please don't hesitate to chime back in / create a new PR.

@mhalbritter mhalbritter added status: declined and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 1, 2024
@mhalbritter mhalbritter closed this Feb 1, 2024
@eltonsandre
Copy link
Author

Hi @mhalbritter,
Thanks...

Yes, in a way, this plugin is recent, but it was separated from this plugin Spring-boot-helper, currently with 617K downloads, precisely to separate the Starter Spring initializr feature so that Intellij Community has access to the Spring initializr feature.

@mhalbritter
Copy link
Contributor

Thanks for that information. I'll flagged the issue and we'll talk about that in our next meeting.

@mhalbritter
Copy link
Contributor

I'm a bit confused. If there is already the (well known) Spring Boot Helper plugin, why did you copy the initializer feature into the Spring Initializr plugin? And what happens if I install both?

Or did you move the initializer functionality?

It also says on the Spring Initializr plugin that it depends on the Spring Boot Helper plugin. If I need both, why not leave the initializer functionality in the Spring Boot Helper plugin?

@eltonsandre
Copy link
Author

eltonsandre commented Feb 7, 2024

The initializer functionality has been moved from spring-boot-helper.
spring-boot-helper does not depend on spring-initializ and can be used alone, without the need for the 2 plugins.

In the case of spring-initializr, in this version there are still some dependencies on spring-boot-helper, which will be removed in the next versions. The evolutionary idea is that they are modular without dependencies.

@mhalbritter
Copy link
Contributor

Okay, so in the final form it will look like this:

  • Spring Boot helper plugin provides Boot related functionality, but not project creation
  • Spring Initialzr plugin provides only the project creation functionality
  • Neither of the plugins depend on the other, they are both standalone.

Is this correct?

May I ask what the reason for that change was? Users requested to only have the project creation functionality?

@eltonsandre
Copy link
Author

eltonsandre commented Feb 8, 2024

correct.
the motivation is to make the functionalities modular, without one depending on the other.
Similar to the built-in Spring plugins that already exist in Intellij Ultimate

@mhalbritter
Copy link
Contributor

I see, thank you for that explanation. I'll discuss it with the team, but I'm leaning toward merging the PR.

@mhalbritter
Copy link
Contributor

mhalbritter commented Feb 9, 2024

I'm happy to merge that PR as soon as the dependency on Spring Boot Helper is removed. Right now, if I install the Initializr plugin in my community edition IntelliJ, it also installs the Spring Boot helper and I'm told I need to activate a license for the Spring Boot helper.

Please chime in back here as soon as the dependency is removed. Thanks!

@eltonsandre
Copy link
Author

Ok, is the blocking factor the dependency or the linked license?

Don't get me wrong, but it seems unfair...
Because the scenario of Intellij IDEA Ultimate(UI) is the same, it is only possible to use the Spring Initialzr functionality through a license. And if you choose the license, it does not offer the possibility of use in the Intellij IDEA Community(IC).

Although there is a dependency and license (symbolic value, much lower than the UI license for access to the functionality), it is still an open functionality that can be used in the IC itself and in the UI.

image
image

@mhalbritter
Copy link
Contributor

I absolutely don't have a problem that you want to make money with the software you write.

The blocking factor is the UX for the end user. They use Community edition because they can't or don't want to pay for the enterprise features. Then your plugin would put the start.spring.io feature into the community edition, but it depends on a plugin which needs a license.

@mhalbritter
Copy link
Contributor

mhalbritter commented Sep 25, 2024

The plugin website now says "This plugin is unavailable due to its non-compliance with the JetBrains Marketplace Content Moderation Policy.". I'm closing this PR.

@eltonsandre
Copy link
Author

Hi @mhalbritter,
Yes, JetBrains pointed out this restriction, as the plugin name is identical to the built-in.
The name tweak has already been uploaded and will be available within 2 days, it will be called "Spring Initializr Helper".

Legal or contractual ground for the restriction:
According to JetBrains Marketplace Approval Guidelines the plugin name must be an original and unique name. However, the name of the above mentioned plugin completely copies the name of the JetBrains' plugin available at: https://plugins.jetbrains.com/plugin/20212-spring-initializr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants