feat: Migrate Actions #532
Conversation
|
🚀 Preview at https://40f44e49.dataflow-website.pages.dev |
| with: | ||
| message-id: cloudflare-deploy | ||
| message: | | ||
| 🚀 Preview at ${{ steps.cloudflare-publish.outputs.url }} |
| with: | ||
| node-version: 18.2.0 | ||
|
|
||
| # setup cf cli with bg plugin and login |
There was a problem hiding this comment.
Is this something we will want to add going forward? If not, I would be in favor of just removing the commented code. By the time that we decide to use the commented code it will likely be out of date.
| name: Build site | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
Do you mind bumping this to @v4?
| # plugin-id: blue-green-deploy | ||
| # login: true | ||
|
|
||
| # do site build and prepare for cf push |
There was a problem hiding this comment.
Ha! I am guessing "cf push" here means "CloudFlare push" and not the predecessor well-know "cf push" for CloudFoundry.
| with: | ||
| apiToken: ${{ secrets.CF_API_TOKEN }} | ||
| accountId: ${{ secrets.CF_ACCOUNT_ID }} | ||
| projectName: ${{ secrets.CF_PROJECT_NAME }} |
There was a problem hiding this comment.
The other secrets are org secrets. This one is repo secret. Can you share this w/ me so I can add to our Vault store w/ the other scdf secrets?
| id: cloudflare-publish | ||
| uses: cloudflare/pages-action@v1 | ||
| with: | ||
| apiToken: ${{ secrets.CF_API_TOKEN }} |
There was a problem hiding this comment.
I am sure you did not choose these secret names as they are at the org level, but CF_ screams CloudFoundry. Who in the heck does CloudFlare think it is trying to gobble up the historical CloudFoundry CF_ prefix 🤣
| message-id: cloudflare-deploy | ||
| message: | | ||
| 🚀 Preview at ${{ steps.cloudflare-publish.outputs.url }} | ||
| # Chat Notification |
There was a problem hiding this comment.
I would be in favor of removing this commented out code and then re-adding later when/if we decide to do that.
Preview looks good @oodamien . I love this auto-generated-PR comment w/ a link to the site preview. I took it for a spin and seems good. The redirects are not expected to work at this phase, correct? |
| pull-requests: write | ||
|
|
||
| jobs: | ||
| # build and deploy staging |
There was a problem hiding this comment.
A couple of infos:
- This comment says we are deploying into
staging - The workflow file is named
prod-build-* - The output generates a preview link (I am guessing this is staging)
- We have the commented out blue/green deploy action below
A couple of questions:
- What is the output of this PR before the merge.
- What is the output once the PR is merged?
- How do we get to production?
Resolves #531
Resolves #531