Using dlists can result in "node.getContext() is not a function" error #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpfeiffer
force-pushed
the
fix-node-getcontext-not-a-function
branch
from
35d49c5
to
f949dca
Compare
Avoid crashing with "node.getContext() is not a function" Quote from https://asciidoctor.github.io/asciidoctor.js/main/#listitem "In a description list (dlist), each item is a tuple that consists of a 2-item Array of ListItem terms and a ListItem description (i.e., [[term, term, ...], desc]. If a description is not set, then the second entry in the tuple is nil."
cpfeiffer
force-pushed
the
fix-node-getcontext-not-a-function
branch
from
f949dca
to
afbbe0c
Compare
philwebb
changed the title
philwebb
pushed a commit
that referenced
this pull request
Nov 5, 2024
Protect against array nodes such as `dlist`. Quote from https://asciidoctor.github.io/asciidoctor.js/main/#listitem "In a description list (dlist), each item is a tuple that consists of a 2-item Array of ListItem terms and a ListItem description (i.e., [[term, term, ...], desc]. If a description is not set, then the second entry in the tuple is nil." See gh-5
philwebb
added a commit
that referenced
this pull request
Nov 5, 2024
|
Thanks @cpfeiffer. Sorry it's taken so long to get to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem described in #4. Instead of aborting, it logs a warning and keeps on validating.