Remove deprecated DockerComposeRule.waitingForService method #6041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the usage of this deprecated method with the waitingForService(String serviceName, HealthCheck<Container> healthCheck, ReadableDuration timeout) method. resolves issue spring-cloud#6013 Signed-off-by: Glenn Renfro <[email protected]>
onobc
reviewed
Oct 30, 2024
| @@ -36,6 +36,7 @@ VersionInfoProperties versionInfoProperties, SecurityStateBean securityStateBean | |||
| ** stopAll | |||
| ** getStepNamesForJob | |||
| * The following deprecated `Converters` have been removed from SCDF: `AbstractDateTimeConverter`, `DateToStringConverter`, and `StringToDateConverter`. Use the converters provided by Spring Batch. | |||
| * `DockerComposeRule.waitingForService(String serviceName, HealthCheck<Container> healthCheck)` has been replaced by `DockerComposeRule.waitingForService(String serviceName, HealthCheck<Container> healthCheck, ReadableDuration timeout)`. | |||
There was a problem hiding this comment.
You got the "update the Whats New in the same PR" thing going... 🎉
|
@onobc you only had to remind me 3 times 😆 |
|
Rebased Merged. Thanks @onobc for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the usage of this deprecated method with the waitingForService(String serviceName, HealthCheck healthCheck, ReadableDuration timeout) method.
resolves issue #6013
Signed-off-by: Glenn Renfro [email protected]