Remove deprecations from AppRegistryController #6039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Oct 30, 2024
| @@ -224,7 +223,7 @@ else if (entry.getKey().equals("outbound")) { | |||
| * @param type module type | |||
| * @param name module name | |||
| * @param version module version | |||
| * @param bootVersion module boot version or {@code null} to use the default | |||
| * @param bootVersion module boot version or {@code null} to use the default. Deprecated: bootVersion is no longer needed when registering an app. | |||
There was a problem hiding this comment.
I have mixed feelings about leaving this in since there is no Boot2/3 in SCDF 3.x. However, since it is a controller it is the upgrade empathy thing to do to leave it in and mark @Deprecated. Do you mind adusting the desc to say that the parameter is ignored completely?
The original issue states to remove deprecated functions. However, this would remove some of SCDF's default behavior when registering applications. In that it can look the suffix of the URL to obtain the version. The original Issues for the PR that put in the deprecations just wanted to give the user the ability to override the version. Also deprecated the use of bootVersion when registering an app. Resolves spring-cloud#6011 Signed-off-by: Glenn Renfro <[email protected]>
Added entry to whats-new.adoc Updated javadoc for register method.
|
Updated per code review request. Thanks @onobc for the review!!!!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue states to remove deprecated functions. However, this would remove some of SCDF's default behavior when registering applications. In that it can look the suffix of the URL to obtain the version. The original Issues for the PR that put in the deprecations just wanted to give the user the ability to override the version.
Also deprecated the use of bootVersion when registering an app.
Resolves #6011