Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Improve k8s setup scripts. #5942

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

corneil
Copy link
Contributor

@corneil corneil commented Sep 18, 2024

Updated k8s setup scripts to improve consistency in options available to various use-* scripts for initializing the BROKER, DATABASE, NS and other kubectl related configuration.

Copy link
Contributor

@ilayaperumalg ilayaperumalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -19,12 +19,4 @@ echo "Connecting to $TMC_CLUSTER"
tmc cluster auth kubeconfig get $TMC_CLUSTER > $HOME/.kube/config
export KUBECONFIG=$HOME/.kube/config
shift
if [ "$1" != "" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a separate note, I think we can remove and clean-up all the TMC related scripts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to rename all the tmc scripts to tpe. They are likely to be similar.

@corneil corneil merged commit 1297af7 into spring-cloud:main Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants