Update to 2.11.5-SNAPSHOT #5904
Merged
+65
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Aug 23, 2024
onobc
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Thanks for the updates @corneil .
The changes for the snapshot update look good.
However, I don't think we want to update the stream apps version in 2.11.x though as that would switch the default apps version in a patch release for the carvel packages. We are already updating to the latest apps in main-3.
Please submit a PR w/ only the snapshot updates.
cppwfs
requested changes
Aug 23, 2024
onobc
reviewed
Aug 26, 2024
The docs specify that the registration scripts uses 2022.0.0 |
onobc
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to snapshot.
Updates local test deployment scripts to register 2024.0.0/5.0.0 stream apps.