Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #5436

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Replace deprecated command with environment file #5436

merged 1 commit into from
Sep 13, 2023

Conversation

jongwooo
Copy link
Contributor

Description

Closes #5435

Update .github/actions/build-repository-bundle/action.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=bundle-path::$REPO_BUNDLE_GENERATED"

TO-BE

echo "bundle-path=$REPO_BUNDLE_GENERATED" >> $GITHUB_OUTPUT

Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this @jongwooo

@onobc onobc merged commit 80796d6 into spring-cloud:main Sep 13, 2023
3 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch September 13, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
2 participants