Adds failover data centers to DiscoveryClient. Fixes gh-712 #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new property in discovery client configuration, a list named failoverDataCenters. If discovery client cannot find instance of wanted service in local cluster it will look for instances of that service in given data centers.
|
@Vojislav-Cuk Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Vojislav-Cuk Thank you for signing the Contributor License Agreement! |
|
IMO I think we should get all instances from all configured data centers, and then only fail over to other data centers in the case that the instances in the current data center are not responsive. |
|
My reasoning for this was that failover to other datacenters should be a rare occurrence. And these failover datacenters could also be very remote. So expensive calls to remote datacenters should be as rare as possible. |
spencergibb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new property in discovery client configuration, a list named
failoverDataCenters.If discovery client cannot find instance of wanted service in local
cluster it will look for instances of that service in given data centers.
See #712