feature: apis for tag, video #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added fetch api for video added api to add tag remove tag api added upload for video
| ATTRIBUTES += %i[video_attributes] | ||
| mattr_reader *ATTRIBUTES | ||
|
|
||
| @@video_attributes = [:product_id, :url, :file, :tag_name, tag_names: []] |
There was a problem hiding this comment.
why is tags not nested attribute and tag_names instead?
and why should we have both tag_name and tag_names?
| end | ||
|
|
||
| def add_tag | ||
| tag_names = params[:video][:tag_names] || [] |
There was a problem hiding this comment.
should not tags be auto handled via nested params?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASKS: