-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a possibility to leave comments in connection to a text segment/tag #86
Comments
Should the comment be compulsory for Are there any other tags that should allow (or enforce) comments? |
As discussed in yesterday's meeting, the idea is that a comment text field should be visible, as a separate widget (below the spaghetti area, for example) for each OBS label added. The data structure should be extended with a list of comments. Some follow-up questions:
@cajosc Do you have any input on where, in the data structure, comments should live?
|
@arildm How about a new field on the label, e.g. comment? It seems reasonable to store comments as close to the labels as possible, if they can't be stored in them. Note (for self) that this requires a small change in the code that exports anonymized essays from the kiosks to the portal. |
Now implemented on https://spraakbanken.gu.se/swell/dev/ When OBS! is added, a comment field appears. The comment is visible and editable when the OBS-labeled edge is selected. It is deleted if the tag is removed. |
Gunlög is having problems with comments disappearing. |
Also, we want to split the OBS label into two. Currently, there is a validation rule that prevents saving as |
Fixed in f3a8460 |
Let's say we have something we don't know how to handle that and we assign a tag "OBS!" We would also want to explain why "OBS" is there.
The text was updated successfully, but these errors were encountered: