Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove input text field from the left side-bar in error-annotation mode #77

Open
elenavolodina opened this issue Jun 1, 2018 · 3 comments

Comments

@elenavolodina
Copy link
Member

No description provided.

@elenavolodina elenavolodina added this to the Sofia's training (June 11-15, 2018) milestone Jun 3, 2018
@jroxendal
Copy link
Collaborator

Pausing this, it might be better to keep the input there to make the filtering more obvious.

@cajosc
Copy link
Contributor

cajosc commented Sep 20, 2018

The input text field is used to enter an identifier for a replacement, e.g. first_name:male_1. Maybe remove it and reuse the text field from #86?

@cajosc cajosc added the size:M label Sep 20, 2018
@cajosc cajosc removed this from the Sofia's training (June 11-15, 2018) milestone Oct 4, 2018
@jroxendal jroxendal self-assigned this Oct 10, 2018
@arildm
Copy link
Member

arildm commented Oct 19, 2018

This could use some discussion.

The text field has two purposes currently: entering a numeric label in anonymization mode, and navigating among labels in both modes (type "ca" and it will highlight "O-CAP", press TAB and it will highlight "M-CASE", then press Enter to add the label). Also, #86 will add free-text comments (in both modes, I assume), which could use the same input field.

Navigating among labels could be done even without the text field, but leaving it visible makes it easier.

I'm not sure it is a good idea to remove the input field. Anyway we might want to postpone this after #86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants