Update service provider to use bindShared().
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $config->addConnection('default', $this->config); | ||
| $config->addConnection('default', [ | ||
| 'dbname' => $credentials['database'], | ||
| 'user' => $credentials['username'], |
There was a problem hiding this comment.
I had the isset checks in the original code here due to the sqlite::memory: connection not needing a username, password, or host. Can you add them back in?
The default laravel configuration does not define all config options for the sqlite connection: https://github.com/laravel/laravel/blob/master/app/config/database.php Add an `isset()` check on `$credentials` for the following index to avoid PHP undefined index notices: $credentials['username'] $credentials['password'] $credentials['host']
|
In my humble opinion, the service providers should stay on a separate repo. It should not be part of the library else you will end up with all frameworks :) . |
|
It's not a bad idea. AWS does this for instance: https://github.com/aws/aws-sdk-php-laravel |
|
@travis-rei yup 👍 |
|
True - it would be much cleaner that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible changes to the Laravel service provider.
Warning: not tested.