Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2658-BE-ECS-Add-instanceMetadataTags-Open-API #702

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

TamirYaariSpot
Copy link
Contributor

@TamirYaariSpot TamirYaariSpot commented Dec 22, 2024

This is the default pull request template. You can customize it by adding a pull_request_template.md at the root of your repo or inside the .github folder.

Jira Ticket

Include a link to your Jira Ticket
Example: DOC-2658

Demo

Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@TamirYaariSpot TamirYaariSpot requested a review from a team as a code owner December 22, 2024 11:51
Copy link
Collaborator

@rickshar rickshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 18: Change to: The required HTTP PUT response hop limit for instance metadata requests.

rickshar
rickshar previously approved these changes Dec 22, 2024
elinornetapp
elinornetapp previously approved these changes Dec 23, 2024
@AvishagK AvishagK dismissed stale reviews from elinornetapp and rickshar via f1ca786 December 23, 2024 07:56
@AvishagK AvishagK merged commit f6c4006 into master Dec 23, 2024
3 checks passed
@AvishagK AvishagK deleted the DOC-2658-BE-ECS-Add-instanceMetadataTags-Open-API branch December 23, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants