-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2165-BE-GKE-Rolls-Tab-Support-Missing-Statuses-Roll-scope-Parameters #700
DOC-2165-BE-GKE-Rolls-Tab-Support-Missing-Statuses-Roll-scope-Parameters #700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvishagK
Change: line 36: Add a breif description or comment about the roll. The comment should be limited to 256 chars.
To
Add a short comment about the roll (up to 256 chars).
Change: Line 44: During the roll, if the parameter is set to true we honor PDB during the instance replacement.
To:
During the roll, if the parameter is set to 'true', PDB is honored during the instance replacement.
Change:line 48:
To: Indicates the threshold percentage of minimum healthy instances in a single batch.
If the number is below the threshold, the cluster roll will fail.
The parameter value has a range of 1-100 (default = 50%).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change:Line 6:
To"
When set to 'True' and virtual node group identifiers are defined to roll,
the specified virtual node group(s) will be blocked from scaling up.
Replacements will scale up in other virtual node groups that match the displaced pods instead. This applies to migrating nodes from one virtual node group to another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 6:
To:
Value is a percentage to set the size of a batch in a roll. Valid values are 0-100.
…Statuses-Roll-scope-Parameters
Hi, |
Hi, |
This is the default pull request template. You can customize it by adding a
pull_request_template.md
at the root of your repo or inside the.github
folder.Jira Ticket
https://spotinst.atlassian.net/browse/DOC-2165
Include a link to your Jira Ticket
Example: JIRAISS-1234
Demo
Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route
Checklist: