Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2165-BE-GKE-Rolls-Tab-Support-Missing-Statuses-Roll-scope-Parameters #700

Conversation

AvishagK
Copy link
Contributor

This is the default pull request template. You can customize it by adding a pull_request_template.md at the root of your repo or inside the .github folder.

Jira Ticket

https://spotinst.atlassian.net/browse/DOC-2165

Include a link to your Jira Ticket
Example: JIRAISS-1234

Demo

Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@AvishagK AvishagK requested a review from a team as a code owner December 19, 2024 11:19
Copy link
Collaborator

@rickshar rickshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvishagK
Change: line 36: Add a breif description or comment about the roll. The comment should be limited to 256 chars.
To
Add a short comment about the roll (up to 256 chars).
Change: Line 44: During the roll, if the parameter is set to true we honor PDB during the instance replacement.
To:
During the roll, if the parameter is set to 'true', PDB is honored during the instance replacement.
Change:line 48:
To: Indicates the threshold percentage of minimum healthy instances in a single batch.
If the number is below the threshold, the cluster roll will fail.
The parameter value has a range of 1-100 (default = 50%).

Copy link
Collaborator

@rickshar rickshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change:Line 6:
To"
When set to 'True' and virtual node group identifiers are defined to roll,
the specified virtual node group(s) will be blocked from scaling up.
Replacements will scale up in other virtual node groups that match the displaced pods instead. This applies to migrating nodes from one virtual node group to another.

Copy link
Collaborator

@rickshar rickshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 6:
To:
Value is a percentage to set the size of a batch in a roll. Valid values are 0-100.

yinnonbar
yinnonbar previously approved these changes Dec 24, 2024
@AvishagK
Copy link
Contributor Author

Change:Line 6: To" When set to 'True' and virtual node group identifiers are defined to roll, the specified virtual node group(s) will be blocked from scaling up. Replacements will scale up in other virtual node groups that match the displaced pods instead. This applies to migrating nodes from one virtual node group to another.

Hi,
please specify the string you want to change from to?
@rickshar

@AvishagK
Copy link
Contributor Author

Line 6: To: Value is a percentage to set the size of a batch in a roll. Valid values are 0-100.

Hi,
please specify the string you want to change from to?
@rickshar

@AvishagK AvishagK changed the title [src] - ocean gke - add scope field DOC-2165-BE-GKE-Rolls-Tab-Support-Missing-Statuses-Roll-scope-Parameters Dec 26, 2024
@AvishagK AvishagK closed this Dec 30, 2024
@AvishagK AvishagK deleted the DOC-2165-BE-GKE-Rolls-Tab-Support-Missing-Statuses-Roll-scope-Parameters branch December 30, 2024 08:53
@AvishagK AvishagK restored the DOC-2165-BE-GKE-Rolls-Tab-Support-Missing-Statuses-Roll-scope-Parameters branch December 30, 2024 08:53
@AvishagK AvishagK deleted the DOC-2165-BE-GKE-Rolls-Tab-Support-Missing-Statuses-Roll-scope-Parameters branch December 30, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants