Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGD-6242 Workspace stuck in starting due to missing volume #255

Merged

Conversation

HafdisE
Copy link
Contributor

@HafdisE HafdisE commented Dec 9, 2024

Jira ticket

https://spotinst.atlassian.net/browse/BGD-6242

Description

Add values config option to be able to specify the storage class of the PVC in the bigdata-notebook-workspace chart.

Demo

Given a values.yaml containing

pvc:
  storageClassName: pvc-ebs

A PVC with the following spec is generated:

spec:
  storageClassName: pvc-ebs
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 10Gi

Without providing a values.yaml:

spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 10Gi

Checklist

  • I have added a Jira ticket link
  • I have filled in the test plan
  • I have executed the tests and filled in the test results
  • I have updated/created relevant documentation

How to test

Helm install the chart with a valid value for pvc.storageClassName and check that it is successful and the PVC gets created with spec.storageClassName set to the provided value.

Test plan and results

Test Description Result Notes
1 Manual helm install with storage class name set PV successfully created using storageClassName requested by PVC
2 Manual helm install without storage class name set PVC no longer specifies a storage class

@HafdisE HafdisE force-pushed the BGD-6242-Workspace-stuck-in-starting-due-to-missing-volume branch 2 times, most recently from 6659608 to 5ffa342 Compare December 10, 2024 14:31
@HafdisE HafdisE marked this pull request as ready for review December 10, 2024 14:57
@HafdisE HafdisE requested a review from a team as a code owner December 10, 2024 14:57
@HafdisE HafdisE merged commit 5ffa2a6 into main Dec 11, 2024
2 checks passed
@HafdisE HafdisE deleted the BGD-6242-Workspace-stuck-in-starting-due-to-missing-volume branch December 11, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants