Always create telemetry ConfigMap #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ImpSy <[email protected]>
|
LGTM, this will make the telemetry enabling/disabling easy as we will no longer require the operator to be updated with telemetry enabled before applying the telemetry bdenv . I will let the @spotinst/team-bigdata-team-leads approve. |
alextarasov-spot
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/BGD-6111
Description
Telemetry should only be enabled by the creation or not of a sidecar
Always creating the telemetry CM has no overhead for customer and ease the development workflow for us
Checklist
How to test
No "feature" here just removal of an if condition
Test plan and results