Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGD-5118 Bigdata Proxy version 0.4.11 #211

Conversation

raggivald
Copy link
Contributor

@raggivald raggivald commented May 26, 2024

Jira Ticket

BGD-5118

Description

Release a new bigdata-proxy version that fixes vulnerabilities discovered in bigdata-proxy
https://github.com/spotinst/bigdata-proxy/pull/61

Checklist

  • I have added a Jira ticket link
  • I have filled in the test plan
  • I have executed the tests and filled in the test results

Test plan and results

Review the following properties
In the bigdata-charts/charts/chart.yaml
appVersion: 0.5.4

In the bigdata-charts/charts/values.yaml
image tag: tag: 0.5.4-4546714a

Upgrade the image to the latest production. proxy image: 0.5.4-4546714a

Run helm upgrade:

helm upgrade bigdata-proxy-bdenv-v67 bigdata-proxy --debug -n spot-system

or directly edit the deployment:

k edit deployment bigdata-proxy-bdenv-v67 -n spot-system
image: 066597193667.dkr.ecr.us-east-1.amazonaws.com/private/bigdata-proxy:0.5.3-3862d889
to
image: 066597193667.dkr.ecr.us-east-1.amazonaws.com/private/bigdata-proxy:0.5.4-4546714a

NOTE: when using helm the operator may quickly move it back to the old version, but when editing it will stay

Make sure a new pod with the new image is started

k get pods
bigdata-proxy-bdenv-v67-7d5f78758c-jwsrp 1/1 Running 0 2m1s

Use the proxy pod you see in your list

k get pods bigdata-proxy-bdenv-v67-7d5f78758c-jwsrp -oyaml
image: 066597193667.dkr.ecr.us-east-1.amazonaws.com/private/bigdata-proxy:0.5.4-4546714a

image

check the logs for the pigdata-proxy-pod

k logs bigdata-proxy-bdenv-v67-7d5f78758c-jwsrp
Make sure the new image 0.5.4-4546714a is running
Make sure there are no errors in the log content

image

Run devctl integration tests

devctl
control-plane
test
run-with-params
--token=
--accountId=act-12f6b1b9
--clusterId=<Cluster_Id>
--optimizer-url=https://api.spotinst.io
--spark-versions=3.2.1,3.4.0

Tests should complete without errors

image image

...

@raggivald raggivald requested a review from a team as a code owner May 26, 2024 14:32
Copy link
Contributor

@alextarasov-spot alextarasov-spot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
since we update libraries versions and it is hard to test that there are no braking changes, please, run the image on your DP cluster and make screenshots/short recording that everything is working. Even run integration tests https://spotinst.atlassian.net/wiki/spaces/BD/pages/2731966640/DevCTL+Testing

@raggivald raggivald merged commit 9c7aca0 into main May 29, 2024
1 check passed
@raggivald raggivald deleted the BGD-5118-scan-of-2024-04-29-fix-vulnerabilities-discovered-in-bigdata-proxy branch May 29, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants