Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGD-4696-Fix-jupyterlab-extensions-mechanism #181

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

BGD-4696-Fix-jupyterlab-extensions-mechanism #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
078f945
dont run workspaces as root
sigmarkarl Jan 24, 2024
7d26795
dont run workspaces as root
sigmarkarl Jan 24, 2024
b21dd06
start-notebook.sh deprecated use start-notebook.py
sigmarkarl Jan 24, 2024
16b07bd
Merge branch 'BGD-4414-dont-run-workspace-as-root' of https://github.…
sigmarkarl Feb 7, 2024
c88517a
Update values.yaml
sigmarkarl Feb 8, 2024
5a06a85
Merge branch 'main' into BGD-4696-Fix-jupyterlab-extensions-mechanism
sigmarkarl Feb 9, 2024
656d45a
update tag to 4.1.0
sigmarkarl Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/bigdata-notebook-workspace/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ spec:
- containerPort: {{ .Values.containerPort.port }}
name: {{ .Values.containerPort.name }}
command:
- start-notebook.sh
- start-notebook.py
args:
{{- range $key, $value := .Values.server }}
- --ServerApp.{{ $key | snakecase }}={{$value}}
Expand Down
6 changes: 1 addition & 5 deletions charts/bigdata-notebook-workspace/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ image:
repository: public.ecr.aws/ocean-spark/bigdata-notebook
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: lab-4.0.10-ofas-d35201c
tag: lab-4.1.0-ofas-ea68b6c

imagePullSecrets:
- name: spot-bigdata-image-pull
Expand Down Expand Up @@ -49,10 +49,6 @@ volume:
name: workspace-data
mountPath: /home/jovyan

podSecurityContext:
runAsUser: 0
fsGroup: 0

containerPort:
port: 8888
name: workspace
Expand Down
Loading