[gcp] Fix BQ BIGNUMERIC type support #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
force-pushed
the
bigquery-bignumeric
branch
from
0f972d0
to
e09ffa0
Compare
RustedBones
commented
Jul 11, 2024
Comment on lines
-53
to
-54
| s"POINT($i $i)", // geography is not an avro logical type | ||
| s"""{"value":$i}""" // json is not an avro logical type |
There was a problem hiding this comment.
I found out that BQ adds custom sqlType property to the schema. We can reconstruct the original type
RustedBones
commented
Jul 11, 2024
| q"""(r: _root_.org.apache.avro.generic.GenericRecord) => { | ||
| import _root_.scala.jdk.javaapi.CollectionConverters._ | ||
| ${constructor(tpe, tn)} |
There was a problem hiding this comment.
This is technically an Ident(TermName("r")), adapt macro
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5428 +/- ##
==========================================
+ Coverage 61.09% 61.12% +0.03%
==========================================
Files 310 311 +1
Lines 11060 11075 +15
Branches 769 764 -5
==========================================
+ Hits 6757 6770 +13
- Misses 4303 4305 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIGNUMERICis currently not properly supported.toTablecannot infer a schema of typeBIGNUMERICBIGNUMERICtable returns badly convertedBigDecimal(using wrong scale/precision)Introduce new type
BigNumericto solve this issue