Enable global access for VPC access scope (#49)

spotify · Jun 17, 2021 · 2719b42 · 2719b42
1 parent 2588382
commit 2719b42
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/controllers/flinkcluster_converter.go b/controllers/flinkcluster_converter.go
@@ -300,7 +300,10 @@ func getDesiredJobManagerService(
 	case v1beta1.AccessScopeVPC:
 		jobManagerService.Spec.Type = corev1.ServiceTypeLoadBalancer
 		jobManagerService.Annotations =
-			map[string]string{"networking.gke.io/load-balancer-type": "Internal"}
+			map[string]string{
+				"networking.gke.io/load-balancer-type":                         "Internal",
+				"networking.gke.io/internal-load-balancer-allow-global-access": "true",
+			}
 	case v1beta1.AccessScopeExternal:
 		jobManagerService.Spec.Type = corev1.ServiceTypeLoadBalancer
 	case v1beta1.AccessScopeNodePort:

diff --git a/controllers/flinkcluster_converter_test.go b/controllers/flinkcluster_converter_test.go
@@ -494,7 +494,8 @@ func TestGetDesiredClusterState(t *testing.T) {
 				RevisionNameLabel: "flinkjobcluster-sample-85dc8f749",
 			},
 			Annotations: map[string]string{
-				"networking.gke.io/load-balancer-type": "Internal",
+				"networking.gke.io/load-balancer-type":                         "Internal",
+				"networking.gke.io/internal-load-balancer-allow-global-access": "true",
 			},
 			OwnerReferences: []metav1.OwnerReference{
 				{