Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of nose #529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

get rid of nose #529

wants to merge 1 commit into from

Conversation

MeggyCal
Copy link

As nose is unmaintained for a while, let us replace it with unittest.

@MeggyCal MeggyCal force-pushed the master branch 3 times, most recently from 4870677 to 114da2a Compare January 20, 2021 15:51
@MeggyCal
Copy link
Author

... and tests don't work, because I don't know how to setup your environment :( would you help me with that, please?

@erikbern
Copy link
Collaborator

Thanks for the PR! I think it fails because of something with how python setup.py nosetests builds the library before it runs the test. You might have to add a separate step to build the module first. I can clone and take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeggyCal @erikbern