fix: spotbugs plugin is not loaded from v5.0.15 #930
Conversation
Signed-off-by: Kengo TODA <[email protected]>
Signed-off-by: Kengo TODA <[email protected]>
Signed-off-by: Kengo TODA <[email protected]>
Signed-off-by: Kengo TODA <[email protected]>
Signed-off-by: Kengo TODA <[email protected]>
KengoTODA
changed the title
Signed-off-by: Kengo TODA <[email protected]>
| @@ -13,7 +13,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| gradle: ['7.0', '8.0'] | |||
There was a problem hiding this comment.
Gradle 7.0 does not support FooJay plugin, so need to bump up the minimal version to 7.6.2. This change does NOT mean that our users need to use 7.6.2 or later.
| @@ -72,5 +72,6 @@ tasks { | |||
| } | |||
| } | |||
| tasks.check { | |||
| dependsOn(tasks.named("functionalTest")) | |||
There was a problem hiding this comment.
This change is necessary to run functional test cases during the CI workflow.
| import spock.lang.Requires | ||
| import spock.lang.Specification | ||
|
|
||
| import static org.gradle.testkit.runner.TaskOutcome.SUCCESS | ||
|
|
||
| @Ignore |
There was a problem hiding this comment.
This functional test is not working, and we have less contribution on Android support (refs #90) so simply ignore this specification for now.
| """ | ||
| new File(rootDir, "settings.gradle.kts") << """ | ||
| plugins { | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version("0.6.0") |
There was a problem hiding this comment.
We need this setting to use the Gradle Java toolchain with Gradle 8.0+.
| "configuration for the external SpotBugs plugins excluding transitive dependencies") | ||
| .create(SpotBugsPlugin.PLUGINS_CONFIG_NAME) | ||
| .setDescription("configuration for the external SpotBugs plugins") | ||
| .setVisible(false) |
There was a problem hiding this comment.
The internal configuration (actualSpotbugsPlugins) is needless because the FindBugs plugin is always distributed with its dependencies so no need to add transient dependencies to spotbugsClasspath. See PluginLoader for detail, it uses Class-Path metadata of jar file to find dependencies.
Signed-off-by: Kengo TODA <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
|
I want to release this change to fix a known regression, so let me merge this for now. There is no additional test case nor new behavior then it should be OK I believe. |
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Signed-off-by: Kengo TODA <[email protected]>
I merged #925 to fix a known bug, but it introduced a regression.
We could not find this regression because functional test cases were not triggered during the CI workflow. So this PR contains two kinds of fixes:
functionalTesttask running during our CI workflow