Fix compile error with single explicit assert in switch expression branch (#1845) #2033
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2033 +/- ##
============================================
+ Coverage 80.44% 81.87% +1.42%
- Complexity 4337 4613 +276
============================================
Files 441 448 +7
Lines 13534 14450 +916
Branches 1707 1830 +123
============================================
+ Hits 10888 11831 +943
+ Misses 2008 1942 -66
- Partials 638 677 +39 ☔ View full report in Codecov by Sentry. |
Vampire
force-pushed
the
issue-1845
branch
7 times, most recently
from
14a8e21
to
f07a139
Compare
AndreasTu
reviewed
Nov 5, 2024
| if (!(code instanceof BlockStatement)) { | ||
| BlockStatement block = new BlockStatement(); | ||
| block.addStatement(code); | ||
| expr.setCode(block); |
There was a problem hiding this comment.
Strange that the code block is marked as not covered, is there a test case missing?
There was a problem hiding this comment.
Hm, strange, shouldn't. That test below should exactly trigger this two times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1845