Fix @RepeatUntilFailure extension with unknown iteration count #2031
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2031 +/- ##
============================================
+ Coverage 80.44% 81.86% +1.41%
- Complexity 4337 4609 +272
============================================
Files 441 448 +7
Lines 13534 14445 +911
Branches 1707 1829 +122
============================================
+ Hits 10888 11826 +938
+ Misses 2008 1942 -66
- Partials 638 677 +39 ☔ View full report in Codecov by Sentry. |
Vampire
force-pushed
the
fix-repeat-until-failure
branch
4 times, most recently
from
0bd3ed9
to
e34cb87
Compare
AndreasTu
previously approved these changes
Nov 3, 2024
.../src/main/java/org/spockframework/runtime/extension/builtin/RepeatUntilFailureExtension.java
Show resolved
Hide resolved
Vampire
force-pushed
the
fix-repeat-until-failure
branch
from
e34cb87
to
a9f299a
Compare
Vampire
force-pushed
the
fix-repeat-until-failure
branch
from
a9f299a
to
e191dcf
Compare
AndreasTu
requested changes
Nov 4, 2024
Vampire
force-pushed
the
fix-repeat-until-failure
branch
from
e191dcf
to
872367f
Compare
AndreasTu
previously approved these changes
Nov 5, 2024
Vampire
force-pushed
the
fix-repeat-until-failure
branch
from
872367f
to
f6d44c4
Compare
AndreasTu
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.