Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 7.6 and fixing lots of issues #1563

Merged
merged 10 commits into from
Feb 16, 2023

Conversation

leonard84
Copy link
Member

@leonard84 leonard84 commented Jan 26, 2023

  • Apply local fix for Problem with Gradle 7.5 spring-io/nohttp#55
  • Update io.spring.nohttp to version 0.0.11
  • Update com.gradle.enterprise to version 3.12.3
  • Update com.github.ben-manes.to versions to version 0.45.0
  • Update biz.aQute.bnd.builder to version 6.4.0
  • Remove org.gradle.test-retry as it is integrated into gradle-enterprise

@leonard84 leonard84 self-assigned this Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 79.78% // Head: 78.18% // Decreases project coverage by -1.60% ⚠️

Coverage data is based on head (0a0fcb5) compared to base (0d64a71).
Patch coverage: 86.25% of modified lines in pull request are covered.

❗ Current head 0a0fcb5 differs from pull request most recent head dcfdb1f. Consider uploading reports for the commit dcfdb1f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1563      +/-   ##
============================================
- Coverage     79.78%   78.18%   -1.60%     
+ Complexity     4076     3992      -84     
============================================
  Files           421      422       +1     
  Lines         12880    12921      +41     
  Branches       1666     1675       +9     
============================================
- Hits          10276    10102     -174     
- Misses         1992     2195     +203     
- Partials        612      624      +12     
Impacted Files Coverage Δ
...spockframework/mock/runtime/GroovyMockFactory.java 72.22% <0.00%> (-9.03%) ⬇️
...in/java/org/spockframework/util/SpockDocLinks.java 85.71% <85.71%> (ø)
...n/java/org/spockframework/util/ReflectionUtil.java 77.39% <88.88%> (-3.32%) ⬇️
...in/java/org/spockframework/util/VersionNumber.java 86.44% <92.45%> (+4.62%) ⬆️
...spockframework/mock/CannotCreateMockException.java 66.66% <100.00%> (ø)
...g/spockframework/mock/runtime/JavaMockFactory.java 100.00% <100.00%> (ø)
...ockframework/spring/xml/SpockNamespaceHandler.java 0.00% <0.00%> (-100.00%) ⬇️
...rk/spring/xml/WrapWithSpyBeanDefinitionParser.java 0.00% <0.00%> (-100.00%) ⬇️
...framework/spring/xml/MockBeanDefinitionParser.java 0.00% <0.00%> (-90.00%) ⬇️
...pockframework/spring/xml/SpockMockFactoryBean.java 0.00% <0.00%> (-87.50%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Apply local fix for spring-io/nohttp#55
Update io.spring.nohttp to version 0.0.11
Update com.gradle.enterprise to version 3.12.3
Update com.github.ben-manes.to versions to version 0.45.0
Update biz.aQute.bnd.builder to version 6.4.0
Remove org.gradle.test-retry as it is integrated into gradle-enterprise
against reflection permission errors.
Prior to version 7.5, Gradle added some `--add-opens` flags,
that hid potential issues with tests, for Java 16+.

gradle/gradle#20999
It seems that @nAmed stopped working with Spring 6,
honestly I have no idea why.
As it works fine with @qualifier the problem seems to be on the Spring
side, so to unblock this change will go with that.
@leonard84 leonard84 changed the title Update to Gradle 7.6 ... Update to Gradle 7.6 and fixing lots of issues Feb 16, 2023
@leonard84 leonard84 merged commit 630e22a into spockframework:master Feb 16, 2023
@leonard84 leonard84 deleted the update-gradle-7.6 branch February 16, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant