Make @Retry repeatable (#1030) #1197
Conversation
| for different situations: | ||
|
|
||
| [source,groovy] | ||
| ---- |
There was a problem hiding this comment.
we want code backed docs where ever possible
Codecov Report
@@ Coverage Diff @@
## master #1197 +/- ##
=========================================
Coverage 75.96% 75.96%
Complexity 3647 3647
=========================================
Files 393 393
Lines 11113 11113
Branches 1369 1369
=========================================
Hits 8442 8442
Misses 2192 2192
Partials 479 479
Continue to review full report at Codecov.
|
Vampire
force-pushed
the
repeatable-retry-annotation
branch
4 times, most recently
from
d2e2b5e
to
3b4d2e3
Compare
Vampire
force-pushed
the
repeatable-retry-annotation
branch
from
3b4d2e3
to
1bd9edb
Compare
| def sql = Sql.newInstance("jdbc:h2:mem:", "org.h2.Driver") | ||
|
|
||
| // tag::example-d[] | ||
| @Retry(exceptions = IllegalArgumentException, count = 2) |
There was a problem hiding this comment.
Should we add a test, that actually alternately throws both these exceptions?
There was a problem hiding this comment.
That is unfortunately a good idea, though in the test spec, not the doc spec.
Unfortunately, because I think the changes were too naive for the retry extension logic to properly work in that case in its current state. I have to rework that probably when I'm a bit less sleepy.
There was a problem hiding this comment.
Or you might have a look, as you invented the whole extension and probably know the code better than me.
| @@ -44,7 +46,7 @@ private boolean noSubSpecWithRetryAnnotation(SpecInfo spec) { | |||
| } | |||
|
|
|||
| private boolean noRetryAnnotation(NodeInfo node) { | |||
| return !node.getReflection().isAnnotationPresent(Retry.class); | |||
| return !node.isAnnotationPresent(Retry.class); | |||
Make @Retry repeatable (#1030)
This change is