Skip to content

Commit

Permalink
Review Feedback Vol. 1
Browse files Browse the repository at this point in the history
  • Loading branch information
Vampire committed Jan 7, 2025
1 parent 06f0bea commit 96a2d8a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ plugins {
}

dependencies {
implementation(libs.workflows.kotlin.compiler.embeddable)
implementation(libs.workflows.kotlin.compilerEmbeddable)
}

gradlePlugin {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ class PreprocessWorkflowsPlugin implements Plugin<Project> {
def libs = project.extensions.getByType(VersionCatalogsExtension).find('libs').orElseThrow(AssertionError::new)
def kotlinCompilerClasspath = project.configurations.detachedConfiguration(
libs.findLibrary('workflows-kotlin-compiler').orElseThrow(AssertionError::new).get(),
libs.findLibrary('workflows-kotlin-scripting-compiler').orElseThrow(AssertionError::new).get()
libs.findLibrary('workflows-kotlin-scriptingCompiler').orElseThrow(AssertionError::new).get()
)
def kotlinScriptClasspath = project.configurations.detachedConfiguration(
libs.findLibrary('workflows-kotlin-main-kts').orElseThrow(AssertionError::new).get()
libs.findLibrary('workflows-kotlin-mainKts').orElseThrow(AssertionError::new).get()
).tap {
it.transitive = false
}
Expand Down
8 changes: 4 additions & 4 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jacoco = '0.8.12'
junit = '5.11.4'
asm = '9.7.1'
mockito4 = '4.11.0'
mockito5 = '5.15s.2'
mockito5 = '5.15.2'
workflows-kotlin = "2.0.20"

[libraries]
Expand Down Expand Up @@ -35,9 +35,9 @@ junit-jupiter.module = "org.junit.jupiter:junit-jupiter"
junit-platform-testkit.module = "org.junit.platform:junit-platform-testkit"
junit-platform-console.module = "org.junit.platform:junit-platform-console"
workflows-kotlin-compiler = { module = "org.jetbrains.kotlin:kotlin-compiler", version.ref = "workflows-kotlin" }
workflows-kotlin-compiler-embeddable = { module = "org.jetbrains.kotlin:kotlin-compiler-embeddable", version.ref = "workflows-kotlin" }
workflows-kotlin-main-kts = { module = "org.jetbrains.kotlin:kotlin-main-kts", version.ref = "workflows-kotlin" }
workflows-kotlin-scripting-compiler = { module = "org.jetbrains.kotlin:kotlin-scripting-compiler", version.ref = "workflows-kotlin" }
workflows-kotlin-compilerEmbeddable = { module = "org.jetbrains.kotlin:kotlin-compiler-embeddable", version.ref = "workflows-kotlin" }
workflows-kotlin-mainKts = { module = "org.jetbrains.kotlin:kotlin-main-kts", version.ref = "workflows-kotlin" }
workflows-kotlin-scriptingCompiler = { module = "org.jetbrains.kotlin:kotlin-scripting-compiler", version.ref = "workflows-kotlin" }

# just here so that renovate can figure out the dependencies
groovy-v2 = { module = "org.codehaus.groovy:groovy", version.ref="groovy2" }
Expand Down

0 comments on commit 96a2d8a

Please sign in to comment.