feat: add jsonp middleware for mock #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
应该也要能从 package.json 的 spm.server.jsonp 中获取配置，这样多人协作的时候就不需要每个人都加 |
|
@sorrycc 好 我补充下 |
| @@ -36,6 +37,10 @@ function Server(compiler, opts) { | |||
|
|
|||
| var app = this.app = koa(); | |||
|
|
|||
| // support jsonp | |||
| if(opts.jsonp || opts.pkg.spm.jsonp) { | |||
There was a problem hiding this comment.
放在 server 里? 另外，opts.pkg.spm.jsonp 要做兼容，pkg 和 spm 都有可能不存在。
| request(app.listen()) | ||
| .get('/x.json') | ||
| .expect(function(res){ | ||
| if(res.text.should.be.eql('{\n "hello": "world"\n}\n') === 0) throw new Error('Can not get right json content'); |
There was a problem hiding this comment.
res.text.should.be.eql(...) 不就行了么，不用自己抛出异常吧？
|
能否说明下这个的场景，为什么不是默认支持？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add jsonp middleware for mock