Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete in binding.py now same as get/post #575

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DanielPerezJensen
Copy link

Currently you can not pass custom headers to delete, as they are overwritten with default self._auth_headers. Replaced that with all_headers as in get and put.

Currently you can not pass custom headers to delete, as they are overwritten with default self._auth_headers. Replaced that with all_headers as in get and put.
@DanielPerezJensen
Copy link
Author

This change is required to leverage .delete using splunklib. Current work is blocked by this, as deletion is not possible without header authentication. Please have a look at this, or any other way we can expedite this.

@DanielPerezJensen
Copy link
Author

Saw in another PR wanting to solve the same thing, to add a test case. Where would you suggest I do that? In which testing file is this functionality tested usually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant