Logback Encoder Support for HEC #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: logback encoder support for HEC * feat: testcontainers in test suite * feat: start container at suite level * feat: test json message with logstash encoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logback Encoder Support for HEC
Related Issues: #284
PR Summary
Encoders are now supported for the HEC appender, with layout now deprecated in the same fashion as the TCP appender. I have verified that JSON payloads are correctly sent using the popular logstash-logback-encoder with
messageFormatset tojson.Acceptance and Stress Suites are all green.
PR Changes
HttpEventCollectorLogbackAppenderaccepts an encoder and automatically wraps a layout in the same manner as the tcp appender.net.logstash.logback.encoder.LogstashEncoderwith json message format utilized in the logback.xml to mimic real world usage within the test suite.test.yml, to work with the Testcontainers approach.PR Added Dependencies