-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): merge develop to main #386
Open
mkolasinski-splunk
wants to merge
13
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description (PR description goes here) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
Fix for failing `Parse JUnit XML` job in upgrade tests.
### Description Upgrade tests exclusions for automatic execution on PRs to main, etc. (defined here: https://github.com/splunk/addonfactory-workflow-addon-release/blob/main/.github/workflows/reusable-build-test-release.yml#L176) were not working because the condition for `run-upgrade-tests` job added in this PR was missing. Running upgrade tests automatically on all events the same way as other test types is not desired right now. As per current design, upgrade tests should be executed only when explicitly specified - by assigning `execute_upgrade` label. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done - all tests (including upgrade tests) automatically executed before implementing the fix: https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13540341896 - all tests (except upgrade tests) automatically executed after implementing the fix: https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/13545440706
### Description (PR description goes here) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description Upgrade tests execution based on labels wasn't configured properly. Due to variable name of the job output being incorrect, the upgrade tests were not executed when the `execute_upgrade` label was assigned to the PR. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done - workflow without the fix - upgrade tests **not executed** with `execute_upgrade` label assigned: https://github.com/splunk/splunk-add-on-for-google-cloud-platform/pull/798/checks?sha=7797eec5e91a83687fd47ab458d641ac25fcb131 - workflow after the fix - upgrade tests **executed properly** with `execute_upgrade` label assigned: https://github.com/splunk/splunk-add-on-for-google-cloud-platform/pull/798/checks?sha=cb6b6febff5f5580fa44ccab1c6c0a79b21d454e
### Description ## Allow for TA to specify Splunk Latest as the only version to run WFE tests against. It is too expensive to run all WFE tests on all supported Splunk versions on every commit in CDC add-ons on every commit / PR. Let TA to specify the condition to run WFE tests on latest only. * Full run takes 2d 20h 31m 27s https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13389640676/usage * Latest run takes 17h 29m 24s https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13478849153/usage ## Proposal Default condition - Run WFE tests on all Splunk Versions for conditions: * push to main, develop * PR to main Run only on Splunk latest when: * scheduled execution * Everything else Introduce `wfe-run-on-splunk-latest` input for TA to be precise when it needs a custom rule to run or not run on latest ## +Fix `Summary of Versions Used` should take its value from `steps.determine_splunk.outputs.matrixSplunk` ### Checklist - [ ] `README.md` has been updated or is not required - [x] push trigger tests - [ ] manual release test - [ ] automated releases test - [x] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here) --------- Co-authored-by: mkolasinski-splunk <[email protected]>
### Description This PR fixes failing pre-publish job and introduces passing output to publish job instead. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done Publish done: https://github.com/splunk/test-addonfactory-repo/actions/runs/13566246210/job/37920798879 Publish skipped: https://github.com/splunk/test-addonfactory-repo/actions/runs/13565248938 https://github.com/splunk/test-addonfactory-repo/actions/runs/13548190067/job/37866019352 --------- Co-authored-by: kdoroszko-splunk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This release include:
Checklist
README.md
has been updated or is not requiredTesting done
https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13568681041
PR to main scenario: https://github.com/splunk/splunk-add-on-for-salesforce/actions/runs/13568730203
PR to develop scenario: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/13568715908
release scenario: https://github.com/splunk/test-addonfactory-repo/actions/runs/13566246210