Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): merge develop to main #386

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

mkolasinski-splunk
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk commented Feb 27, 2025

Description

This release include:

  • upgrade tests fixes
  • spl2 content tests adjustments
  • conditions limiting tests execution to latest splunk
  • fix for setup job to properly install dependencies in edge cases
  • fix for pre-publish job to pass arguments to publish job instead of failing a workflow

Checklist

  • README.md has been updated or is not required
  • push trigger tests
  • manual release test
  • automated releases test
  • pull request trigger tests
  • schedule trigger tests
  • workflow errors/warnings reviewed and addressed

Testing done

https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13568681041
PR to main scenario: https://github.com/splunk/splunk-add-on-for-salesforce/actions/runs/13568730203
PR to develop scenario: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/13568715908
release scenario: https://github.com/splunk/test-addonfactory-repo/actions/runs/13566246210

awownysz-splunk and others added 13 commits February 14, 2025 13:01
### Description

(PR description goes here)

### Checklist

- [ ] `README.md` has been updated or is not required
- [ ] push trigger tests
- [ ] manual release test
- [ ] automated releases test
- [ ] pull request trigger tests
- [ ] schedule trigger tests
- [ ] workflow errors/warnings reviewed and addressed

### Testing done 
(for each selected checkbox, the corresponding test results link should
be listed here)
Fix for failing `Parse JUnit XML` job in upgrade tests.
### Description

Upgrade tests exclusions for automatic execution on PRs to main, etc.
(defined here:
https://github.com/splunk/addonfactory-workflow-addon-release/blob/main/.github/workflows/reusable-build-test-release.yml#L176)
were not working because the condition for `run-upgrade-tests` job added
in this PR was missing.

Running upgrade tests automatically on all events the same way as other
test types is not desired right now. As per current design, upgrade
tests should be executed only when explicitly specified - by assigning
`execute_upgrade` label.

### Checklist

- [ ] `README.md` has been updated or is not required
- [ ] push trigger tests
- [ ] manual release test
- [ ] automated releases test
- [ ] pull request trigger tests
- [ ] schedule trigger tests
- [ ] workflow errors/warnings reviewed and addressed

### Testing done 
- all tests (including upgrade tests) automatically executed before
implementing the fix:
https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13540341896
- all tests (except upgrade tests) automatically executed after
implementing the fix:
https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/13545440706
### Description

(PR description goes here)

### Checklist

- [ ] `README.md` has been updated or is not required
- [ ] push trigger tests
- [ ] manual release test
- [ ] automated releases test
- [ ] pull request trigger tests
- [ ] schedule trigger tests
- [ ] workflow errors/warnings reviewed and addressed

### Testing done 
(for each selected checkbox, the corresponding test results link should
be listed here)
### Description

Upgrade tests execution based on labels wasn't configured properly. Due
to variable name of the job output being incorrect, the upgrade tests
were not executed when the `execute_upgrade` label was assigned to the
PR.

### Checklist

- [ ] `README.md` has been updated or is not required
- [ ] push trigger tests
- [ ] manual release test
- [ ] automated releases test
- [ ] pull request trigger tests
- [ ] schedule trigger tests
- [ ] workflow errors/warnings reviewed and addressed

### Testing done 
- workflow without the fix - upgrade tests **not executed** with
`execute_upgrade` label assigned:
https://github.com/splunk/splunk-add-on-for-google-cloud-platform/pull/798/checks?sha=7797eec5e91a83687fd47ab458d641ac25fcb131
- workflow after the fix - upgrade tests **executed properly** with
`execute_upgrade` label assigned:
https://github.com/splunk/splunk-add-on-for-google-cloud-platform/pull/798/checks?sha=cb6b6febff5f5580fa44ccab1c6c0a79b21d454e
### Description

## Allow for TA to specify Splunk Latest as the only version to run WFE
tests against.

It is too expensive to run all WFE tests on all supported Splunk
versions on every commit in CDC add-ons on every commit / PR. Let TA to
specify the condition to run WFE tests on latest only.

* Full run takes 2d 20h 31m 27s
https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13389640676/usage
* Latest run takes 17h 29m 24s
https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13478849153/usage

## Proposal
Default condition - Run WFE tests on all Splunk Versions for conditions:
   *  push to main, develop
   * PR to main

Run only on Splunk latest when:
   * scheduled execution
   * Everything else

Introduce `wfe-run-on-splunk-latest` input for TA to be precise when it
needs a custom rule to run or not run on latest

## +Fix
`Summary of Versions Used` should take its value from
`steps.determine_splunk.outputs.matrixSplunk`

### Checklist

- [ ] `README.md` has been updated or is not required
- [x] push trigger tests
- [ ] manual release test
- [ ] automated releases test
- [x] pull request trigger tests
- [ ] schedule trigger tests
- [ ] workflow errors/warnings reviewed and addressed

### Testing done 
(for each selected checkbox, the corresponding test results link should
be listed here)

---------

Co-authored-by: mkolasinski-splunk <[email protected]>
### Description

This PR fixes failing pre-publish job and introduces passing output to
publish job instead.

### Checklist

- [ ] `README.md` has been updated or is not required
- [ ] push trigger tests
- [ ] manual release test
- [ ] automated releases test
- [ ] pull request trigger tests
- [ ] schedule trigger tests
- [ ] workflow errors/warnings reviewed and addressed

### Testing done 
Publish done:

https://github.com/splunk/test-addonfactory-repo/actions/runs/13566246210/job/37920798879

Publish skipped:

https://github.com/splunk/test-addonfactory-repo/actions/runs/13565248938

https://github.com/splunk/test-addonfactory-repo/actions/runs/13548190067/job/37866019352

---------

Co-authored-by: kdoroszko-splunk <[email protected]>
@mkolasinski-splunk mkolasinski-splunk requested a review from a team as a code owner February 27, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants