Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(npm): prepublish checks on every PR #1543

Merged
merged 5 commits into from
Jan 28, 2025
Merged

ci(npm): prepublish checks on every PR #1543

merged 5 commits into from
Jan 28, 2025

Conversation

vtsvetkov-splunk
Copy link
Contributor

@vtsvetkov-splunk vtsvetkov-splunk commented Jan 23, 2025 •
edited
Loading

Issue number:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

  • Install UI deps before publishing
  • Add a manual workflow for manual publishing of existing tags
  • Replace dry-run with actual publish on publish

User experience

No changes

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@vtsvetkov-splunk
ci(npm): prepublish checks on every PR
a17593d 
Signed-off-by: Viktor Tsvetkov <[email protected]>
@vtsvetkov-splunk
ci(npm): prepublish checks on every PR
1a13c9c 
Signed-off-by: Viktor Tsvetkov <[email protected]>
@vtsvetkov-splunk
frfr
ec2c243 
Signed-off-by: Viktor Tsvetkov <[email protected]>
@vtsvetkov-splunk vtsvetkov-splunk requested a review from a team as a code owner January 23, 2025 16:29
artemrys
artemrys previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see the progress!

@vtsvetkov-splunk
export tarball
e4220ef 
Signed-off-by: Viktor Tsvetkov <[email protected]>
@vtsvetkov-splunk vtsvetkov-splunk requested a review from a team January 23, 2025 16:55
@vtsvetkov-splunk vtsvetkov-splunk self-assigned this Jan 23, 2025
@vtsvetkov-splunk vtsvetkov-splunk enabled auto-merge (squash) January 23, 2025 18:24
@vtsvetkov-splunk vtsvetkov-splunk added the javascript Pull requests that update Javascript code label Jan 27, 2025
@vtsvetkov-splunk vtsvetkov-splunk merged commit 3777638 into develop Jan 28, 2025
123 checks passed
@vtsvetkov-splunk vtsvetkov-splunk deleted the feature/npm-publish-dry-run branch January 28, 2025 10:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soleksy-splunk soleksy-splunk soleksy-splunk approved these changes

@artemrys artemrys artemrys approved these changes

Assignees

@vtsvetkov-splunk vtsvetkov-splunk

Labels
javascript Pull requests that update Javascript code size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtsvetkov-splunk @artemrys @soleksy-splunk