Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proxy component #1444

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

feat: proxy component #1444

wants to merge 14 commits into from

Conversation

hetangmodi-crest
Copy link
Contributor

Issue number: ADDON-72372

Summary

Similar to logging component, we now have a proxy component, also introduced a new argument --need-proxy which includes default proxy configuration during init method

Changes

  • Just like logging component we now have a new type proxyTab which gives default proxy configuration, so that user doesn't have to mention default configuration themselves they just have to mention their custom configurations.

  • Introduced a new argument in init method that is --need-proxy, which includes default proxy configuration in globalConfig.json during creation of new add-on.

  • Changed the approach of fetching proxy_details inoauth template file. For that created a function in solnlib which fetches proxy_details and validates proxy_host and proxy_port.

User experience

Changes according to UX point of view :

  • If user have to use our default configuration of proxy they just need to define type=proxyTab in their globalConfig.
  • They can add their custom validations for any field, but they would have to use some specific keys for that
    for ex. If a user wants to customize the label of port they would just have to write
    { "type": "proxyTab", "port": { "label": "Proxy port", } }
  • Now users can validate their port and hostnames of proxy through get_proxy_dict function of solnlib.
  • While initializing an add-on user will have extra parameter --need-proxy which includes default proxy configuration in globalConfig.json.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@hetangmodi-crest hetangmodi-crest added the enhancement New feature or request label Nov 11, 2024
@hetangmodi-crest hetangmodi-crest self-assigned this Nov 11, 2024
@artemrys
Copy link
Member

@hetangmodi-crest please fix pre-commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants