-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: proxy component #1444
Open
hetangmodi-crest
wants to merge
14
commits into
develop
Choose a base branch
from
feat/proxy-component
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: proxy component #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-72372
Summary
Similar to logging component, we now have a proxy component, also introduced a new argument
--need-proxy
which includes default proxy configuration duringinit
methodChanges
Just like logging component we now have a new type
proxyTab
which gives default proxy configuration, so that user doesn't have to mention default configuration themselves they just have to mention their custom configurations.Introduced a new argument in
init
method that is--need-proxy
, which includes default proxy configuration inglobalConfig.json
during creation of new add-on.Changed the approach of fetching proxy_details in
oauth template
file. For that created a function in solnlib which fetches proxy_details and validatesproxy_host
andproxy_port
.User experience
type=proxyTab
in their globalConfig.for ex. If a user wants to customize the label of
port
they would just have to write{ "type": "proxyTab", "port": { "label": "Proxy port", } }
get_proxy_dict
function of solnlib.--need-proxy
which includes default proxy configuration inglobalConfig.json
.Checklist
If your change doesn't seem to apply, please leave them unchecked.