fix: unique values only across single service #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemrys
changed the title
soleksy-splunk
force-pushed
the
feat/unique-names-only-across-service
branch
from
f083710 to
160f147
Compare
soleksy-splunk
changed the title
vtsvetkov-splunk
previously approved these changes
Jan 23, 2025
artemrys
reviewed
Jan 23, 2025
|
This would resolve #1369. |
| @@ -259,7 +259,7 @@ const CustomTable: React.FC<CustomTableProps> = ({ | |||
| data.length && | |||
| data.map((row) => ( | |||
| <CustomTableRow // nosemgrep: typescript.react.best-practice.react-props-spreading.react-props-spreading | |||
| key={row.name || row.id} | |||
| key={`${row.serviceName}-${row.name}-row` || row.id} | |||
There was a problem hiding this comment.
Suggested change
| key={`${row.serviceName}-${row.name}-row` || row.id} | |
| key={`${row.serviceName}-${row.name}-row`} |
the second part is unreachable
There was a problem hiding this comment.
yea weird mistake, i probably wanted to create sth like:
key={row.name ? ${row.serviceName}-${row.name}-row : row.id}
but i think name should always be there so maybe no need for this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
https://splunk.atlassian.net/browse/ADDON-77229
resolves #1369
Summary
Ui now verifies uniqueness of inputs service names only across data for each service.
Changes
UI verification for service name to exist has been narrowed down.
User experience
Right now user can create inputs with the same name for different services.
Checklist
If your change doesn't seem to apply, please leave them unchecked.